Whats wrong with my minecraft server?

I made a server doing everything right. I port forward right. example i have verizon and did this. specify ip my ip tcp and udp and put port 25565. And then i built the server correctly. So i run the server and it says it runing. I tell people to join it giving them my ip and they cant. did i do anything wrong? oh yeah my os is windows xp professional and i need to update my graphic cards and i play of the internet